WIP: Add abort event #3929
Closed
WIP: Add abort event #3929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This event will be emitted when gracefulStop is called. It's a temporary solution to avoid issues when SIGTERMs are handled by k6, but not by downstream modules such as the browser module.
This is a temporary solution to a problem the browser module is facing when a signal (e.g. SIGTERM) is handled by k6, but is not correctly handled by the browser module. The reason is due to it not working with the vu context. More details in the open issue: grafana/xk6-browser#1410. The introduction of a temporary abort event will be fired, which the browser module can intercept and action on immediately.
ankur22
requested review from
olegbespalov and
joanlopez
and removed request for
a team
|
Closing as we found a working solution: grafana/xk6-browser#1420 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds a temporary Abort event which would signal to subscribers that k6 has received a termination signal from somewhere (REST, OS, etc).
Why?
The browser module currently isn't relying on the VU Context to control the iteration lifecycle. There is an open issue to move it over to working with the VU Context. A quick fix is to add an Abort event which will inform the browser module to close any chromium instances down, which will force any waiting API calls to exit since the connection to chromium has ended.
Checklist
make lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)
Updates: https:/grafana/k6-cloud/issues/2664