Query Path Fixes #1079
Merged
Query Path Fixes #1079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
joe-elliott
requested review from
annanay25,
dgzlopes,
kvrhdn,
mapno and
mdisibio
as code owners
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
joe-elliott
commented
Oct 27, 2021
| @@ -27,7 +27,7 @@ func PublishHedgedMetrics(s *hedgedhttp.Stats) { | |||
| ticker := time.NewTicker(hedgedMetricsPublishDuration) | |||
| go func() { | |||
| for range ticker.C { | |||
| hedgedRequestsMetrics.Add(float64(s.Snapshot().RequestedRoundTrips)) | |||
| hedgedRequestsMetrics.Set(float64(s.Snapshot().RequestedRoundTrips)) | |||
There was a problem hiding this comment.
counters don't allow you to set them directly. is there a better way to do this?
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
mdisibio
approved these changes
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Fixes two issues in the query path:
The more I work on the query path the more it feels a little duct taped together. We should regroup and redesign this one day.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]