Add filtering by namespace in non-tempo alerts #1098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mapno
requested review from
annanay25,
dgzlopes,
joe-elliott,
kvrhdn and
mdisibio
as code owners
kvrhdn
reviewed
Nov 5, 2021
kvrhdn
approved these changes
Nov 8, 2021
CHANGELOG.md
Outdated
| @@ -73,6 +73,7 @@ | |||
| * [ENHANCEMENT] Include tempo-cli in the release [#1086](https:/grafana/tempo/pull/1086) (@zalegrala) | |||
| * [ENHANCEMENT] Add search on span status [#1093](https:/grafana/tempo/pull/1093) (@mdisibio) | |||
| * [ENHANCEMENT] Slightly improved compression performance [#1094](https:/grafana/tempo/pull/1094) (@bboreham) | |||
| * [ENHANCEMENT] Jsonnet: add `$._config.namespace` to filter by namespace in cortex metrics [#1098](https:/grafana/tempo/pull/1098) (@kvrhdn) | |||
There was a problem hiding this comment.
Can you merge latest changes from main and move this entry up?
mapno
force-pushed
the
configurable-namespace-mixin
branch
from
896530c
to
7079b54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds a configurable namespace label to cortex metrics used for alerts. This can be useful if you're running tempo and cortex in the same cluster.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]