Remove Push from tempopb.Pusher #1173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvrhdn
requested review from
annanay25,
dgzlopes,
joe-elliott,
mapno,
mdisibio and
zalegrala
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Remove the
Pushmethod fromtempopb.Pusher.I noticed
Pusheris implemented by both the distributor and the ingester, but:PushBytesPushis deprecated for the ingester. This change was introduced in January (Switch distributor->ingester communication to more efficient PushBytes method #430). It was a breaking change back then so I don't think this is a breaking change again now.I also noticed none of the
Pushermethods in distributor were used. The OTel Receiver shim defines its own interfaceBatchPusher. So I deleted this implementation.