Per tenant max search duration #1421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
joe-elliott
requested review from
knylander-grafana,
KMiller-Grafana,
annanay25,
mdisibio,
dgzlopes,
mapno,
kvrhdn and
zalegrala
as code owners
Signed-off-by: Joe Elliott <[email protected]>
knylander-grafana
requested changes
May 4, 2022
Co-authored-by: Kim Nylander <[email protected]>
knylander-grafana
approved these changes
May 4, 2022
Signed-off-by: Joe Elliott <[email protected]>
mdisibio
reviewed
May 4, 2022
| @@ -70,6 +70,9 @@ type Limits struct { | |||
| // Querier enforced limits. | |||
| MaxBytesPerTagValuesQuery int `yaml:"max_bytes_per_tag_values_query" json:"max_bytes_per_tag_values_query"` | |||
|
|
|||
| // QueryFrontend enforced limits | |||
| MaxSearchDuration model.Duration `yaml:"max_search_duration" json:"max_search_duration"` | |||
There was a problem hiding this comment.
Is there a reason for model.Duration? Just comparing to MetricsGeneratorCollectionInterval time.Duration above.
There was a problem hiding this comment.
I think we use model.Duration b/c it supports marshalling to and from JSON as well as YAML whereas time.Duration seems to only support YAML. There are 3 model.Duration fields and only 1 time.Duration.
mdisibio
approved these changes
May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds the ability to have a per tenant max search duration. By default, if there is no per tenant configuration, the original config value is used. This PR also updates the jsonnet under
./operationsto mount the overrides yaml onto the frontend.Additional changes
block_retentionoverrideChecklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]