Fix an inconsistency in wal search #1548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdisibio
requested review from
joe-elliott,
annanay25,
dgzlopes,
mapno,
kvrhdn and
zalegrala
as code owners
annanay25
approved these changes
Jul 6, 2022
joe-elliott
pushed a commit
to joe-elliott/tempo
that referenced
this pull request
Jul 7, 2022
* Move flatbuffer search extract methods from distributor to reuseable location * Move trace test suite to reusable location * Run trace search tests against wal and backend search blocks. Fix wal header tag check to be substring * lint * changelog * review feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR is a followup to #1538. It runs the same comprehensive search tests against the two block types in the ingester: wal (StreamingSearchBlock) and completed (BackendSearchBlock). A bug was found and addressed in the StreamingSearchBlock header tag check.
The comprehensive test cases in /tempodb/ were moved to /pkg/model/trace and made reusable, as well as the tag extraction logic from the distributor. These two PRs are in preparation for #1547.
Which issue(s) this PR fixes:
Fixes n/a
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]