Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Generic Forwarding documentation #1872

Merged
merged 2 commits into from
Nov 16, 2022
Merged

Add Generic Forwarding documentation #1872

merged 2 commits into from
Nov 16, 2022

Conversation

Blinkuu
Copy link
Contributor

@Blinkuu Blinkuu commented Nov 8, 2022

What this PR does:

This PR adds documentation for the Generic Forwarding feature introduced in #1775.

Checklist

  • Documentation added

@Blinkuu Blinkuu added the type/docs Improvements or additions to documentation label Nov 8, 2022
@Blinkuu Blinkuu self-assigned this Nov 8, 2022
@Blinkuu Blinkuu changed the title Add generic forwarder docs Add generic forwarder documentation Nov 8, 2022
@Blinkuu Blinkuu changed the title Add generic forwarder documentation Add generic forwarding documentation Nov 9, 2022
@Blinkuu Blinkuu changed the title Add generic forwarding documentation Add Generic Forwarding documentation Nov 9, 2022
Copy link
Contributor

@knylander-grafana knylander-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start on the docs, especially the clear comments in the config options file. Well done. I have some additional comments in the other doc

@Blinkuu Blinkuu marked this pull request as ready for review November 10, 2022 08:39
Copy link
Contributor

@knylander-grafana knylander-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you for writing the doc.

@knylander-grafana
Copy link
Contributor

@Blinkuu I wasn't sure if I was supposed to merge or if you would like to, so I haven't merged this PR. Thank you for writing the doc for this!

@Blinkuu
Copy link
Contributor Author

Blinkuu commented Nov 14, 2022

@knylander-grafana I'm not authorized to merge this PR. Perhaps only code owners can do so? Please merge it if you can.

@joe-elliott joe-elliott merged commit eac504a into grafana:main Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants