Fix Ingesters Occassionally Double Flushing #364
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Occassionally ingesters fail to flush due to a double queuing (#217) issue discovered by @calvernaz. This PR looks to fix that by:
ExclusiveQueues
that prevents multiple items from being queued with the same keyflushLoop()
to either call.Requeue()
or.ClearKey()
after flush has failed or succeeded./pkg/util/test
stopping()
eep!Which issue(s) this PR fixes:
Fixes #217
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]