Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add json struct tags to Limits #656

Merged
merged 1 commit into from
Apr 20, 2021
Merged

Conversation

kavirajk
Copy link
Contributor

@kavirajk kavirajk commented Apr 20, 2021

What this PR does:
Add json struct tags to limits struct. To be consistent with cortex and loki

Which issue(s) this PR fixes:
Fixes NA

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@CLAassistant
Copy link

CLAassistant commented Apr 20, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@annanay25 annanay25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

CHANGELOG.md Outdated Show resolved Hide resolved
@annanay25 annanay25 merged commit 597a19a into main Apr 20, 2021
@annanay25 annanay25 deleted the json-struct-tags-overrides branch April 20, 2021 10:04
@annanay25 annanay25 mentioned this pull request Apr 20, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants