Compression Updates #961
Merged
Compression Updates #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
This reverts commit b68b038.
Signed-off-by: Joe Elliott <[email protected]>
joe-elliott
requested review from
annanay25,
dgzlopes,
kvrhdn,
mapno and
mdisibio
as code owners
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
mdisibio
approved these changes
Sep 15, 2021
Closed
klauspost
reviewed
Sep 21, 2021
|
|
||
| // PutWriter places back in the pool a CompressionWriter | ||
| func (pool *S2Pool) PutWriter(writer io.WriteCloser) { | ||
| pool.writers.Put(writer) |
There was a problem hiding this comment.
Maybe add a writer.Close() to ensure it is flushed.
joe-elliott
added a commit
to joe-elliott/tempo
that referenced
this pull request
Sep 21, 2021
This reverts commit b89f2ae.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]