Skip to content

Commit

Permalink
Move handleFrameTree
Browse files Browse the repository at this point in the history
handleFrameTree is called when a new frame session is created for a new
frame that is attached. Some of these frames are not mainframes but do
contains a tree structures with child frames. If we don't handle the
frame tree for these non-mainframes, this will prevent navigations from
being handled for these frames and a panic/error which would stop the
test iteration.
  • Loading branch information
ankur22 committed May 24, 2024
1 parent 4a6e086 commit 21d3226
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion common/frame_session.go
Original file line number Diff line number Diff line change
Expand Up @@ -406,8 +406,9 @@ func (fs *FrameSession) initFrameTree() error {
return fmt.Errorf("got a nil page frame tree")
}

fs.handleFrameTree(frameTree)

if fs.isMainFrame() {
fs.handleFrameTree(frameTree)
fs.initRendererEvents()
}
return nil
Expand Down

0 comments on commit 21d3226

Please sign in to comment.