Incorrect frame used after getting ownerFrame in checkHitTargetAt

[ankur22]

What?

Looking at some code and i think this is incorrect, but it needs to be investigated with some working examples. frame is retrieved with h.ownerFrame, and later checked to see if frame != nil && frame.parentFrame != nil. In the if condition, the frame isn't used, instead h.frame. I would imagine that we should be working with the frame that was retrieved instead of h.frame.

Why?

This is confusing, and there are no comments or anything in the history to help us understand why we implemented it this way. Looking at Playwright, I can't find anywhere where they get the ownerFrame but then not use the result. This could be causing some unexpected incorrect behaviour when it comes to interacting with the website.

How?

We should:

1. Create test scripts and integration tests that use the checkHitTargetAt in ElementHandle.
2. Change the code so it works with frame instead of h.frame.
3. See if the change helps in any way.

Tasks

Tasks

Beta Give feedback

1. PR
2. Update the k6 release notes

Related PR(s)/Issue(s)

Could be related to the following issues:

• The coordinate of the element from a frame is incorrect. #967
• nil pointer: page.getFrameElement #1073
• ElementHandle: nil pointer dereference #1056