Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix page and context mappings #1326

Merged
merged 2 commits into from
May 13, 2024
Merged

Fix page and context mappings #1326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
457ea8f
Fix forgotten browser mapping
inancgumus May 10, 2024
f7ce348
Fix forgotten page context mapping
inancgumus May 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion browser/browser_context_mapping.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,10 @@ func mapBrowserContext(vu moduleVU, bc *common.BrowserContext) mapping { //nolin

return bc.AddInitScript(source) //nolint:wrapcheck
},
"browser": bc.Browser,
"browser": func() mapping {
// the browser is grabbed from VU.
return mapBrowser(vu)
},
"clearCookies": bc.ClearCookies,
"clearPermissions": bc.ClearPermissions,
"close": bc.Close,
Expand Down
6 changes: 4 additions & 2 deletions browser/page_mapping.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,10 @@ func mapPage(vu moduleVU, p *common.Page) mapping { //nolint:gocognit,cyclop

return p.Close(opts) //nolint:wrapcheck
},
"content": p.Content,
"context": p.Context,
"content": p.Content,
"context": func() mapping {
return mapBrowserContext(vu, p.Context())
},
"dblclick": p.Dblclick,
"dispatchEvent": func(selector, typ string, eventInit, opts goja.Value) error {
popts := common.NewFrameDispatchEventOptions(p.Timeout())
Expand Down
Loading