Prepare Locator for async migration
#1330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inancgumus
added
mapping
inancgumus
force-pushed
the
async/browsercontext
branch
from
bf7afad
to
9c872c9
Compare
inancgumus
force-pushed
the
async/locator-prepare
branch
from
f524f45
to
bc9daca
Compare
These definitions are about the concrete type, not the mapping. So they should not return a promise.
ankur22
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Turns panics into errors.
Why?
To make the async migration more reliable.
Checklist
Related PR(s)/Issue(s)
#1305