Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare ElementHandle for async migration #1335

Merged
merged 32 commits into from
May 16, 2024
Merged

Prepare ElementHandle for async migration #1335

merged 32 commits into from
May 16, 2024

Commits on May 16, 2024

  1. Fix BoundingBox mapping 

    Although ElementHandle.BoundingBox always returns a nil error (as PW
does), for consistency, it's better to reflect this in the API test
here.
    @inancgumus
    inancgumus committed May 16, 2024
    Configuration menu
    Copy the full SHA
    03a7066 View commit details
    Browse the repository at this point in the history

  2. Refactor ElementHandle.Check to return err

    @inancgumus
    inancgumus committed May 16, 2024
    Configuration menu
    Copy the full SHA
    a1b9955 View commit details
    Browse the repository at this point in the history

  3. Refactor ElementHandle.Uncheck to return err

    @inancgumus
    inancgumus committed May 16, 2024
    Configuration menu
    Copy the full SHA
    b92934c View commit details
    Browse the repository at this point in the history

  4. Refactor ElementHandle.Dblclick to return err

    @inancgumus
    inancgumus committed May 16, 2024
    Configuration menu
    Copy the full SHA
    25b8381 View commit details
    Browse the repository at this point in the history

  5. Refactor ElementHandle.Fill to return err

    @inancgumus
    inancgumus committed May 16, 2024
    Configuration menu
    Copy the full SHA
    893cc77 View commit details
    Browse the repository at this point in the history

  6. Refactor ElementHandle.DispatchEvent to return err

    @inancgumus
    inancgumus committed May 16, 2024
    Configuration menu
    Copy the full SHA
    65d5eb7 View commit details
    Browse the repository at this point in the history

  7. Refactor ElementHandle.Focus to return err

    @inancgumus
    inancgumus committed May 16, 2024
    Configuration menu
    Copy the full SHA
    3135ca9 View commit details
    Browse the repository at this point in the history

  8. Refactor ElementHandle.GetAttribute to return err

    @inancgumus
    inancgumus committed May 16, 2024
    Configuration menu
    Copy the full SHA
    5be5fcd View commit details
    Browse the repository at this point in the history

  9. Refactor ElementHandle.Hover to return err

    @inancgumus
    inancgumus committed May 16, 2024
    Configuration menu
    Copy the full SHA
    f362eea View commit details
    Browse the repository at this point in the history

  10. Refactor ElementHandle.InnerHTML to return err

    @inancgumus
    inancgumus committed May 16, 2024
    Configuration menu
    Copy the full SHA
    6a32c24 View commit details
    Browse the repository at this point in the history

  11. Refactor ElementHandle.InnerText to return err

    @inancgumus
    inancgumus committed May 16, 2024
    Configuration menu
    Copy the full SHA
    a5ca7d2 View commit details
    Browse the repository at this point in the history

  12. Refactor ElementHandle.InputValue to return err

    @inancgumus
    inancgumus committed May 16, 2024
    Configuration menu
    Copy the full SHA
    6982dad View commit details
    Browse the repository at this point in the history

  13. Fix forgotten keyboard tests for error checks 

    It's not related to this PR, but I wanted to tackle them here for
convenience. Apologies for the inconvinience.
    @inancgumus
    inancgumus committed May 16, 2024
    Configuration menu
    Copy the full SHA
    4c00598 View commit details
    Browse the repository at this point in the history

  14. Refactor ElementHandle.IsChecked to return err

    @inancgumus
    inancgumus committed May 16, 2024
    Configuration menu
    Copy the full SHA
    795a56c View commit details
    Browse the repository at this point in the history

  15. Refactor ElementHandle.IsDisabled to return err

    @inancgumus
    inancgumus committed May 16, 2024
    Configuration menu
    Copy the full SHA
    e28d48a View commit details
    Browse the repository at this point in the history

  16. Refactor ElementHandle.IsEditable to return err

    @inancgumus
    inancgumus committed May 16, 2024
    Configuration menu
    Copy the full SHA
    c4d6941 View commit details
    Browse the repository at this point in the history

  17. Refactor ElementHandle.IsEnabled to return err

    @inancgumus
    inancgumus committed May 16, 2024
    Configuration menu
    Copy the full SHA
    e914ee4 View commit details
    Browse the repository at this point in the history

  18. Refactor ElementHandle.IsHidden to return err

    @inancgumus
    inancgumus committed May 16, 2024
    Configuration menu
    Copy the full SHA
    db1849e View commit details
    Browse the repository at this point in the history

  19. Refactor ElementHandle.IsVisible to return err

    @inancgumus
    inancgumus committed May 16, 2024
    Configuration menu
    Copy the full SHA
    2ba400d View commit details
    Browse the repository at this point in the history

  20. Refactor ElementHandle.Press to return err

    @inancgumus
    inancgumus committed May 16, 2024
    Configuration menu
    Copy the full SHA
    ab0f1cc View commit details
    Browse the repository at this point in the history

  21. Remove applySlowMo from QueryAll 

    No need to apply slow motion for querying actions.
    @inancgumus
    inancgumus committed May 16, 2024
    Configuration menu
    Copy the full SHA
    bc6adc1 View commit details
    Browse the repository at this point in the history

  22. Refactor ElementHandle.Screenshot to return err

    @inancgumus
    inancgumus committed May 16, 2024
    Configuration menu
    Copy the full SHA
    9bd5014 View commit details
    Browse the repository at this point in the history

  23. Refactor ElementHandle.ScrollIntoViewIfNeeded to return err

    @inancgumus
    inancgumus committed May 16, 2024
    Configuration menu
    Copy the full SHA
    befc6da View commit details
    Browse the repository at this point in the history

  24. Refactor ElementHandle.SelectOptions to return err

    @inancgumus
    inancgumus committed May 16, 2024
    Configuration menu
    Copy the full SHA
    efab80d View commit details
    Browse the repository at this point in the history

  25. Refactor ElementHandle.SelectText to return err

    @inancgumus
    inancgumus committed May 16, 2024
    Configuration menu
    Copy the full SHA
    c011e5b View commit details
    Browse the repository at this point in the history

  26. Refactor ElementHandle.SetInputFiles for consistency

    @inancgumus
    inancgumus committed May 16, 2024
    Configuration menu
    Copy the full SHA
    d28d6de View commit details
    Browse the repository at this point in the history

  27. Refactor ElementHandle.TextContent to return err

    @inancgumus
    inancgumus committed May 16, 2024
    Configuration menu
    Copy the full SHA
    7fd4406 View commit details
    Browse the repository at this point in the history

  28. Refactor ElementHandle.Type to return err

    @inancgumus
    inancgumus committed May 16, 2024
    Configuration menu
    Copy the full SHA
    1164ef2 View commit details
    Browse the repository at this point in the history

  29. Fix WaitForElementState mapping API

    @inancgumus
    inancgumus committed May 16, 2024
    Configuration menu
    Copy the full SHA
    4aa7023 View commit details
    Browse the repository at this point in the history

  30. Refactor ElementHandle.WaitForElementState to return err

    @inancgumus
    inancgumus committed May 16, 2024
    Configuration menu
    Copy the full SHA
    b1d4c4a View commit details
    Browse the repository at this point in the history

  31. Refactor ElementHandle.Query to return err

    @inancgumus
    inancgumus committed May 16, 2024
    Configuration menu
    Copy the full SHA
    c4e6994 View commit details
    Browse the repository at this point in the history

  32. Refactor errorFromDOMError to return err

    @inancgumus
    inancgumus committed May 16, 2024
    Configuration menu
    Copy the full SHA
    5c968cb View commit details
    Browse the repository at this point in the history