Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use https://crates.io/crates/proc-macro-error #435

Closed
LegNeato opened this issue Oct 9, 2019 · 4 comments
Closed

Use https://crates.io/crates/proc-macro-error #435

LegNeato opened this issue Oct 9, 2019 · 4 comments
Labels
enhancement Improvement of existing features or bugfix good-first-issue

Comments

@LegNeato
Copy link
Member

LegNeato commented Oct 9, 2019

It would be good to use https://crates.io/crates/proc-macro-error to improve error reporting for proc macros.

Basically we should look everywhere we panic() in our proc macros and add span info.
@LegNeato LegNeato added enhancement Improvement of existing features or bugfix good-first-issue labels Oct 9, 2019
@davidpdrsn
Copy link
Contributor

Just wondering, how is that different from syn::Error?

@davidpdrsn
Copy link
Contributor

Ah I see it mentioned in the readme further down. Nvm

@davidpdrsn davidpdrsn mentioned this issue Oct 21, 2019
Closed
3 tasks
@davidpdrsn
Copy link
Contributor

#441 lays the ground work for this. Once that is merged I’ll update the rest of code gen.

@LegNeato LegNeato mentioned this issue Apr 25, 2020
Merged
3 tasks
@LegNeato
Copy link
Member Author

LegNeato commented Jun 6, 2020

This is done.

@LegNeato LegNeato closed this as completed Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improvement of existing features or bugfix good-first-issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LegNeato @davidpdrsn