Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

createSourceEventStream: introduce named arguments and deprecate positional arguments #3634

Merged
merged 5 commits into from
Jun 12, 2022
Merged

createSourceEventStream: introduce named arguments and deprecate positional arguments #3634

merged 5 commits into from
Jun 12, 2022

Commits on Jun 10, 2022

  1. createSourceEventStream: allow named arguments 

    Deprecates the positional arguments to `createSourceEventStream`, to be removed in the next major version.
    @yaacovCR
    yaacovCR committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    4a8c0b5 View commit details
    Browse the repository at this point in the history

  2. apply review feedback

    @yaacovCR
    yaacovCR committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    e8a2a74 View commit details
    Browse the repository at this point in the history

  3. apply feedback

    @yaacovCR
    yaacovCR committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    120ae79 View commit details
    Browse the repository at this point in the history

  4. Remove unnecessary invariant in favor of explicit cast 

    See open TS issue microsoft/TypeScript#31613

Marked with FIXME for when TS feature/bug fix lands upstream

[This code will likely be removed in v17 prior to the feature landing, but may be retained within v16 for longer.]

Similar code "works" at https:/graphql/graphql-js/blob/1f8ba95c662118452bd969c6b26ba4e9050c55da/src/error/GraphQLError.ts#L47 because all the option properties are optional.
    @yaacovCR
    yaacovCR committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    c39e0f3 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2022

  1. add deprecated comment 

    graphql#3635 (comment)
    @yaacovCR
    yaacovCR committed Jun 12, 2022
    Configuration menu
    Copy the full SHA
    f5ebc6f View commit details
    Browse the repository at this point in the history