Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new board - CNC_3040 based on ESP32 module #82

Merged
merged 2 commits into from
Sep 17, 2023

Conversation

shaise
Copy link
Contributor

@shaise shaise commented Sep 17, 2023

Hi @terjeio ,

I have re-forked everything to make a clean pull request.
The changes are rather minor and should not break any other board.

I have also added the board to cmakelists and driver.json. However I dont know where to place all the necessary defines. See my added platformio.cnc3040.ini, this is what I use to compile the driver under vscode.

I quote here for reference the last message from the closed pr #79:

  1. I will look into main/CMakeLists.txt and driver.json and see if I can update it. There is no reason it should not work with the web builder.
  2. I did not touch any of the sub-modules, so I do not know why I see these changes here. I think this is because these sub-modules were updated after my changes and I did nor rebase them correctly. I will look into it, and if the issue will persist, I will refork everything from scratch.
  3. I took quite some care to not change any file that might cause other boards to fail. One of the files: .vscode/launch.jason is auto generated and I think should be removed from the repository. The "big" change I made is to display the mdns status when all the [...] reports are shown. Maybe this is not needed. I use mdns to automatically detect the driver in my sender when it is operating in wifi mode.
  4. I decided to wait before publishing the design files, till I tested it for a while. I did some cutting jobs with it including rotary A axis and it seems to work well so I will upload it soon and let you know. I think I will start a separate repository for it, as to not mix it with my sender, and add links to it from the original repository, as I believe the st32 should be obsolete now. ESP32 is much better. I hope sometime to upgrade it to esp32-s3 as it have considerably more IO's.

Thanks!
shai

@terjeio terjeio merged commit e75e546 into grblHAL:master Sep 17, 2023
1 check failed
@terjeio
Copy link
Contributor

terjeio commented Sep 17, 2023

The "big" change I made is to display the mdns status when all the [...] reports are shown. Maybe this is not needed. I use mdns to automatically detect the driver in my sender when it is operating in wifi mode.

If added to the ESP32 driver then all networking capable drivers should be synchronized. However, I cannot see any reason for adding it - perhaps you have a good one?

@shaise
Copy link
Contributor Author

shaise commented Sep 18, 2023

Hi @terjeio

You are correct, hence I have removed this feature so it is not present in this pr.
I have also uploaded the HW for the keyboard and driver here: https:/shaise/grblHAL_CNC3040
and later I will add some instructions.

BTW - when I try the web builder I get the following error

In file included from main/driver.c:35:
main/./driver.h:177:4: warning: #warning "Compiling for generic board!" [-Wcpp]
#warning "Compiling for generic board!"
^~~~~~~
In file included from main/./driver.h:178,
from main/driver.c:35:
main/./generic_map.h:89:2: error: #error No free pins for keypad!
#error No free pins for keypad!
^~~~~

It looks like it does not find/defined my board. Perhaps I have missed something?

Thanks!

shai

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants