Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Readd get_nvts and get_nvt original calls #1008

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

y0urself
Copy link
Member

What

  • Add the calls to get_nvts and get_nvt back
  • The previous implementation calls get_info, which doesn't return the same results like get_nvts
  • To use the get_nvts call, set extended=True in the get_nvt and get_nvts calls

Why

  • Required functionality

References

GEA-168

Checklist

  • Tests

@y0urself y0urself requested a review from a team as a code owner April 25, 2023 12:59
@y0urself y0urself added the make release To trigger GitHub release action. label Apr 25, 2023
@y0urself y0urself enabled auto-merge (squash) April 25, 2023 13:00
@github-actions
Copy link

Conventional Commits Report

Type Number
Added 1

🚀 Conventional commits found.

@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Merging #1008 (b0f6e4f) into main (3edad27) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head b0f6e4f differs from pull request most recent head 7e4f889. Consider uploading reports for the commit 7e4f889 to get more accurate results

@@            Coverage Diff             @@
##             main    #1008      +/-   ##
==========================================
+ Coverage   98.26%   98.28%   +0.01%     
==========================================
  Files          58       58              
  Lines        4329     4361      +32     
  Branches     1041     1053      +12     
==========================================
+ Hits         4254     4286      +32     
  Misses         59       59              
  Partials       16       16              
Impacted Files Coverage Δ
gvm/protocols/gmpv208/entities/secinfo.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@y0urself y0urself force-pushed the y0urself/reimplement-get-nvts branch from d2aa720 to b0f6e4f Compare April 25, 2023 13:05
bjoernricks
bjoernricks previously approved these changes Apr 25, 2023
@y0urself y0urself merged commit 6e602c4 into main Apr 25, 2023
@y0urself y0urself deleted the y0urself/reimplement-get-nvts branch April 25, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
make release To trigger GitHub release action.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants