Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use poetry instead of pipenv #197

Merged
merged 9 commits into from
Mar 30, 2020
Merged

Use poetry instead of pipenv #197

merged 9 commits into from
Mar 30, 2020

Conversation

bjoernricks
Copy link
Contributor

@bjoernricks bjoernricks commented Mar 27, 2020 •
edited
Loading

Checklist:

@bjoernricks
Add config files for using poetry
963bb0b
@bjoernricks
Use poetry for installation using PEP-517
617b961 
Requires at minimum pip 19.0. Older versions don't support installation
using the process defined in PEP-517.
@bjoernricks
Drop now unused pipenv files
2ab7f3c
@bjoernricks
Adjus circleci config to use poetry instead of pipenv
e36b00b 
In future running `twine` could be replaced by `poetry publish` too but
we should only do one step after another.
@bjoernricks bjoernricks marked this pull request as ready for review March 27, 2020 14:11
@bjoernricks bjoernricks changed the title Poetry Use poetry instead of pipenv Mar 27, 2020
wiegandm
wiegandm requested changes Mar 30, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
RELEASE.md Outdated Show resolved Hide resolved
RELEASE.md Outdated Show resolved Hide resolved
docs/install.rst Outdated Show resolved Hide resolved
wiegandm
wiegandm requested changes Mar 30, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
@bjoernricks
Update docs for poetry usage
3141310 
Keep pipenv in install docs because it may still be useful for somebody.
@bjoernricks
Update release docs
9759f50 
Remove pipenv usage and it replace it by poetry. Also the version will
be maintained in the pyproject.toml file from now on. Additionally
publishing to PyPI is done via CircleCI now.
@bjoernricks
Read version from pyproject.toml file
2f1fc7e 
Add toml as dependency to be able to read the version of python-gvm from
the pyroject.toml file.
@bjoernricks
Add CHANGELOG entry for pipenv to poetry changes
5f7ae70
@bjoernricks
Use venv for testing the testpypi version
5c53cd3
@codecov
Copy link

codecov bot commented Mar 30, 2020

Codecov Report

Merging #197 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #197   +/-   ##
=======================================
  Coverage   91.59%   91.59%           
=======================================
  Files          12       12           
  Lines        1047     1047           
=======================================
  Hits          959      959           
  Misses         88       88

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 603ca6d...5c53cd3. Read the comment docs.

@bjoernricks bjoernricks merged commit 5a85d62 into greenbone:master Mar 30, 2020
@bjoernricks bjoernricks deleted the poetry branch March 30, 2020 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiegandm wiegandm wiegandm approved these changes

@swaterkamp swaterkamp Awaiting requested review from swaterkamp

@y0urself y0urself Awaiting requested review from y0urself

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjoernricks @wiegandm