Additional tests #89
Merged
Additional tests #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because some values are validated against 0 the validation should run if it is not None.
Use same validation for the arguments as in create_schedule
Allow to set the scanner preferences in a task.
Make argument names consitent, remove file_ arguments because they aren't used (but still seem to be supported by gvmd...), add missing supported arguments.
Codecov Report
@@ Coverage Diff @@
## master #89 +/- ##
==========================================
+ Coverage 91.32% 96.18% +4.86%
==========================================
Files 10 10
Lines 2374 2412 +38
==========================================
+ Hits 2168 2320 +152
+ Misses 206 92 -114
Continue to review full report at Codecov.
|
Update create and modify_credential methods to use to_bool helper function for allow_insecure argument.
The auth_algorithm argument isn't required for modify_credential.
wiegandm
approved these changes
Jan 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing tests for modify_schedule and modify_task commands. With this PR we have a full code coverage for generated GMP commands 🎉