-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GRPC Method Descriptor Exposure #55
Comments
That does sound like it makes a good bit of sense - would perhaps allow making some of my own hamfisted attempts to open up access to fields information a bit more elegant. If you wanted to put up a PR, that'd be much appreciated - for my own part, I'm going to be pretty swamped until after the holidays with my day to day. |
You're very correct @artificial-aidan - the method descriptor exposure is pretty straight forward. I'm going to work on a bit of a middle ground on the service and file descriptors, and add them to the base client in an accessible manner, at least for this pass. |
Sounds good to me. Do you still want me to put something together for method descriptors? I think a nice middle ground of providing the basic functionality, while exposing the descriptor protos is a good place to be. If you are leaving the simplicity that this library has created (which is awesome) then maybe you just use the raw protos. |
I have got the method descriptors started, just need to write tests and get it up - should have some time to finish it up in the next day or two. |
#56 When it comes to the Service and File Descriptors - I think that could be accomplished to some degree without major changes by making the currently private Though, rather than tacking that on to this PR - I figured I'd bounce it off of you to see if that idea would match your use case. |
That looks great. And exposing the |
Thanks! Those enhancements will be tracked in Issue 57. Once those are merged to develop, we'll get version 0.1.14 up. |
I'm working on some features in which we are attaching custom options to grpc methods. This can be exposed with something like this:
I had started putting together a PR that exposed the
MethodOptions
output of theGetOptions
call, but then I realized that maybe it just makes sense to put theMethodDescriptor
in theMethodMetadata
instead of pulling out individual fields. This would allow for advanced usage if needed, and not require upkeep.And I guess while at it we could put the
ServiceDescriptor
somewhere as well. And probably theFieldDescriptors
.But the
MethodDescriptor
had the most obvious place to store it.The text was updated successfully, but these errors were encountered: