Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viridianforge/protobuf 4.23 upgrades #19

Merged
merged 3 commits into from
May 17, 2023

Conversation

ViridianForge
Copy link
Collaborator

  • Raises protobuf compatibility to 4.23.0
  • Adds tests for stub and service clients
  • Adds Python 3.11 to test workflows
  • Turns coverage back in on workflows

@ViridianForge ViridianForge merged commit c18e499 into develop May 17, 2023
@ViridianForge ViridianForge deleted the viridianforge/protobuf-4.22-upgrades branch May 17, 2023 04:23
@@ -202,8 +201,10 @@ def _register_methods(self, service_descriptor: ServiceDescriptor) -> Dict[str,
method_name = method_proto.name
method_desc: MethodDescriptor = service_descriptor.methods_by_name[method_name]

input_type = self._symbol_db.GetPrototype(method_desc.input_type)
output_type = self._symbol_db.GetPrototype(method_desc.output_type)
msg_factory = message_factory.MessageFactory(method_proto)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants