Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds/googledirectpath: Check if ipv6 address is non empty #6959

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

zasweq
Copy link
Contributor

@zasweq zasweq commented Feb 1, 2024

This PR checks if the returned ipv6 address is non empty when queried in the google direct path resolver.

RELEASE NOTES: N/A

@zasweq zasweq requested a review from dfawley February 1, 2024 23:22
@zasweq zasweq added this to the 1.62 Release milestone Feb 1, 2024
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Merging #6959 (655a331) into master (cd69b5d) will decrease coverage by 0.02%.
Report is 1 commits behind head on master.
The diff coverage is 65.21%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6959      +/-   ##
==========================================
- Coverage   83.74%   83.72%   -0.02%     
==========================================
  Files         287      287              
  Lines       30929    30915      -14     
==========================================
- Hits        25900    25885      -15     
- Misses       3971     3973       +2     
+ Partials     1058     1057       -1     
Files Coverage Δ
internal/grpcrand/grpcrand_go1.21.go 77.77% <77.77%> (ø)
xds/googledirectpath/utils.go 54.90% <20.00%> (-4.68%) ⬇️

... and 16 files with indirect coverage changes

@zasweq zasweq merged commit 84b85ba into grpc:master Feb 2, 2024
14 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants