Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failures when running electron-rebuild #301

Closed
jlao opened this issue May 1, 2018 · 3 comments
Closed

Build failures when running electron-rebuild #301

jlao opened this issue May 1, 2018 · 3 comments

Comments

@jlao
Copy link

jlao commented May 1, 2018

I'm getting the following build errors when I attempt to run electron-rebuild with grpc.

../deps/grpc/third_party/boringssl/crypto/curve25519/spake25519.c:26:10: fatal error: '../../third_party/fiat/internal.h' file not found
#include "../../third_party/fiat/internal.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

Here are the versions I'm using:

  "dependencies": {
    "grpc": "^1.11.0"
  },
  "devDependencies": {
    "electron": "^1.8.6",
    "electron-rebuild": "^1.7.3"
  }
@nicolasnoble
Copy link
Member

Generally speaking, please don't use electron-rebuild with grpc. It generally messes things up due to it ignoring our installation steps, and not calling into node-pre-gyp.

The best way at that point to get grpc running into Electron is to run the following command:

npm rebuild grpc --runtime=electron --target=1.8.6 --dist-url=https://atom.io/download/electron

That being said, you're getting an error I am not expecting. @murgatroid99 are we sure we packaged sources properly in the npm package ?

@murgatroid99
Copy link
Member

I see the problem. Our package.json doesn't have a generated list of files because that was making npm unhappy. It has a manually curated list of globs, and it doesn't include anything from grpc/third_party/boringssl/third_party.

@nicolasnoble
Copy link
Member

Fixed by #304.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants