Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt swift-testing for Timeout tests #2051

Merged
merged 4 commits into from
Sep 11, 2024

Conversation

glbrntt
Copy link
Collaborator

@glbrntt glbrntt commented Sep 9, 2024

Motivation:

swift-testing has a number of advantages over XCTest (parameterisation, organisation, failure messages etc.), we should start using it instead of XCTest.

Modifications:

  • Convert the Timeout tests

Results:

Better tests

Motivation:

swift-testing has a number of advantages over XCTest (parameterisation,
organisation, failure messages etc.), we should start using it instead
of XCTest.

Modifications:

- Convert the Timeout tests

Results:

Better tests
@glbrntt glbrntt requested a review from gjcairo September 9, 2024 16:11
@glbrntt glbrntt added the v2 A change for v2 label Sep 9, 2024
@glbrntt glbrntt enabled auto-merge (squash) September 9, 2024 16:12
Copy link
Collaborator

@gjcairo gjcairo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful

@glbrntt glbrntt merged commit c51784e into grpc:main Sep 11, 2024
14 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2 A change for v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants