Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review source map unit tests #176

Closed
jamesplease opened this issue Mar 18, 2014 · 4 comments
Closed

Review source map unit tests #176

jamesplease opened this issue Mar 18, 2014 · 4 comments

Comments

@jamesplease
Copy link
Member

The sourcemapin unit tests matches uglify's output but throws a few warnings. This could either be due to an issue with Uglify itself or an issue with the source map that we're inputting.

This is just a note for myself to figure out which of those two it is.

@UltCombo
Copy link
Contributor

Would you mind sharing what warnings are those? As far as I can see, I don't get any warning when executing the grunt test command.

@UltCombo
Copy link
Contributor

Oh wait, I'm having some issues with source maps on Windows.

Even though your patch from #175 did fix the issue, after pulling the latest commit the issue is still present. (?) This might be a derp moment, but I can see the correct code in the files but it is as if not taking effect. I'll try to debug this later and file an issue separately/ask for reopen if needs be.

@jamesplease
Copy link
Member Author

This is what I get:

Running "uglify:sourcemapin" (uglify) task
WARN: Couldn't figure out mapping for ../test/fixtures/src/simple2.js:2,5 → 3,4 []
WARN: Couldn't figure out mapping for ../test/fixtures/src/simple2.js:3,2 → 3,16 []
WARN: Couldn't figure out mapping for ../test/fixtures/src/simple2.js:3,6 → 3,19 []
WARN: Couldn't figure out mapping for ../test/fixtures/src/simple2.js:3,13 → 3,26 []
WARN: Couldn't figure out mapping for ../test/fixtures/src/simple2.js:3,19 → 3,31 []
WARN: Couldn't figure out mapping for ../test/fixtures/src/simple2.js:3,25 → 3,36 []
WARN: Couldn't figure out mapping for ../test/fixtures/src/simple2.js:3,33 → 3,43 []
WARN: Couldn't figure out mapping for ../test/fixtures/src/simple2.js:3,43 → 3,52 []
WARN: Couldn't figure out mapping for ../test/fixtures/src/simple2.js:3,49 → 3,57 []
WARN: Couldn't figure out mapping for ../test/fixtures/src/simple2.js:9,4 → 3,128 []
WARN: Couldn't figure out mapping for ../test/fixtures/src/simple2.js:22,6 → 3,209 []
WARN: Couldn't figure out mapping for ../test/fixtures/src/simple2.js:27,4 → 3,260 []
WARN: Couldn't figure out mapping for ../test/fixtures/src/simple2.js:32,8 → 3,438 []
WARN: Couldn't figure out mapping for ../test/fixtures/src/simple2.js:35,6 → 3,497 []
WARN: Couldn't figure out mapping for ../test/fixtures/src/simple2.js:35,13 → 3,504 []
WARN: Couldn't figure out mapping for ../test/fixtures/src/simple2.js:37,4 → 3,524 []
WARN: Couldn't figure out mapping for ../test/fixtures/src/simple2.js:37,11 → 3,531 []
WARN: Couldn't figure out mapping for ../test/fixtures/src/simple2.js:38,4 → 3,540 []
WARN: Couldn't figure out mapping for ../test/fixtures/src/simple2.js:38,9 → 3,545 []
WARN: Couldn't figure out mapping for ../test/fixtures/src/simple2.js:39,2 → 3,555 []
WARN: Couldn't figure out mapping for ../test/fixtures/src/simple2.js:39,7 → 3,560 []
File tmp/sourcemapin.map created (source map).
File tmp/sourcemapin.js created: 851 B → 619 B

But it still generates the same map that uglify does.

@jamesplease
Copy link
Member Author

Ah, a fresh install of the node_modules got rid of them for me. Going to close this; you should raise another issue or comment here if you find that your problem is still hangin' around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants