Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Upgrading go-getter to v2 in scaffold #3455

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

yhakbar
Copy link
Collaborator

@yhakbar yhakbar commented Oct 7, 2024

Description

Was written to address #3031, but that issue is more closely related to #3460.

It doesn't hurt to merge this in if we don't have any problems with it, though.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Updated go-getter to v2 for the scaffold command.

@yhakbar yhakbar force-pushed the feat/upgrading-go-getter-in-scaffold branch from 2c58feb to b0a7704 Compare October 9, 2024 19:44
@yhakbar yhakbar marked this pull request as ready for review October 9, 2024 20:00
@yhakbar yhakbar merged commit d691e17 into main Oct 16, 2024
5 checks passed
@yhakbar yhakbar deleted the feat/upgrading-go-getter-in-scaffold branch October 16, 2024 17:43
@josh-padnick
Copy link
Contributor

josh-padnick commented Oct 18, 2024

Nit, but is this more of a chore than a feat?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants