Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extracts PSR-17/18 discovery integration and unit tests functionality #3

Merged
merged 1 commit into from
Feb 17, 2022

Conversation

gsteel
Copy link
Owner

@gsteel gsteel commented Feb 17, 2022

Extracts discovery methods into an internal trait and unit tests it.

@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #3 (643f463) into main (107632f) will increase coverage by 4.48%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main       #3      +/-   ##
============================================
+ Coverage     27.30%   31.78%   +4.48%     
  Complexity      215      215              
============================================
  Files            18       19       +1     
  Lines           791      799       +8     
============================================
+ Hits            216      254      +38     
+ Misses          575      545      -30     
Impacted Files Coverage Δ
src/Postmark/PostmarkClientBase.php 0.00% <ø> (ø)
src/Postmark/ClientBehaviour/Discovery.php 100.00% <100.00%> (ø)
src/Postmark/Exception/DiscoveryFailure.php 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 107632f...643f463. Read the comment docs.

@gsteel gsteel merged commit 8f27c94 into main Feb 17, 2022
@gsteel gsteel deleted the extract-discovery branch February 17, 2022 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant