Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docsrs #1487

Merged
merged 3 commits into from
Aug 5, 2023
Merged

Fix docsrs #1487

merged 3 commits into from
Aug 5, 2023

Conversation

pentamassiv
Copy link
Contributor

@pentamassiv pentamassiv commented Aug 5, 2023

This PR includes a few improvements/cleanups regarding building docs on docs.rs:

  • The docs_rs_features option in the Gir.toml was removed. I searched on Github if anybody was using it and I couldn't find anyone. It was also not documented so I don't think anyone used it. It would have complicated with the last point.
  • Since the removal of the dox feature, a few rustc args need to get set in order to build the docs without linking the libraries. They are always the same so we can set them by default in the Cargo.toml of the sys crate.
  • Automatically activate all features of the sys crate so that they all get documented.

@GuillaumeGomez
Copy link
Member

Thanks!

@GuillaumeGomez GuillaumeGomez merged commit 47c2f07 into gtk-rs:master Aug 5, 2023
6 checks passed
@pentamassiv pentamassiv deleted the fix_docsrs branch August 5, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants