record: Differentiate disguised vs pointer types #1530
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disguised types are not pointers, they're just typedefs to a private struct, while pointer types are typedef to a pointer to a private struct. Generate the right code for each.
In C, there are 2 types of "disguised" typdefs:
typedef struct _Blob *Blob
and
typedef struct _Blob Blob
In Gir files, they're both called "disguised", but the first kind also has the "pointer" property set. The current generator only knows about the pointer type.
Currently, it generates
pub type Blob = *mut _Blob;
But , it should do
pub type Blob = _Blob
for the non-pointer type.The effect of this bug is that the rest of the code gen will think that the type is a pointer to a pointer.
So it will generate functions with a signature of
fn func(*mut *mut blob)
instead offn func(*mut blob)