-
-
Notifications
You must be signed in to change notification settings - Fork 62
Conversation
@sdroege Marked as WIP as I'm sure I'll be adding more API soon. But have a look already if you like the direction or not. |
Goes into the right direction IMHO, thanks :) |
So only thing missing here is the |
Yeah, I'll try to add those but for my own needs, the only thing that I know is missing is |
Well without these, the new trait impls are not really useful yet :) |
They are, you can create the Variant from bytes or manually create it (like the array example in my patches). But yeah, w/o those conversions, the API will still be very incomplete. |
Any updates here? |
no. :( If you want to merge what we already have here, let's unmark it as WIP and merge. I can always add additional PRs. |
Without the remaining trait impls it's not really useful yet, so let's just wait :) Too late for this release now anyway, it happened already. |
Sure. :) |
Any updates here? |
No, for me it's not an isolated effort but rather something I've been doing as part of the gvariant addition in zvariant (so it gets some real testing) but there has been more important zbus bugs/issues that I've been looking into, in my limited sparetime before I could continue finishing this work. |
b9d6948
to
ad1e6e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like good progress :)
ad1e6e5
to
bf5c327
Compare
96ce784
to
5dc35f6
Compare
Now just needs to merge cleanly :) Can you remove those "Revert Revert" commits and the gir update commit? |
5dc35f6
to
2c9df92
Compare
Rebased. Although I failed to test the results because:
Cargo clean didn't help, neither did removal of selected folders under |
Nm, needed |
Needs a run of |
This will allow us to create Variant instances from encoded data for container types. The API to query and manipulate a container carying Variant will follow in another patch.
So that `new_from_bytes` can be used with Variant type.
2c9df92
to
4a9a203
Compare
This is useful when combined with the container variant functions and trait implementations from gtk-rs#651. Implementing `ToVariant` would be useful as well, but isn't currently possible: gtk-rs#678
This is useful when combined with the container variant functions and trait implementations from gtk-rs#651. BREAKING CHANGE: This remove `impl<T: ToVariant> From<T> for Variant`, which made it impossible to implement `ToVariant` since it conflicts with the standard library `impl<T> From<T> for T`: gtk-rs#678
This is useful when combined with the container variant functions and trait implementations from gtk-rs#651. BREAKING CHANGE: This remove `impl<T: ToVariant> From<T> for Variant`, which made it impossible to implement `ToVariant` since it conflicts with the standard library `impl<T> From<T> for T`: gtk-rs#678
This is useful when combined with the container variant functions and trait implementations from gtk-rs#651. BREAKING CHANGE: This remove `impl<T: ToVariant> From<T> for Variant`, which made it impossible to implement `ToVariant` since it conflicts with the standard library `impl<T> From<T> for T`: gtk-rs#678
This is useful when combined with the container variant functions and trait implementations from gtk-rs#651. BREAKING CHANGE: This remove `impl<T: ToVariant> From<T> for Variant`, which made it impossible to implement `ToVariant` since it conflicts with the standard library `impl<T> From<T> for T`: gtk-rs#678
This is useful when combined with the container variant functions and trait implementations from gtk-rs/glib#651. BREAKING CHANGE: This remove `impl<T: ToVariant> From<T> for Variant`, which made it impossible to implement `ToVariant` since it conflicts with the standard library `impl<T> From<T> for T`: gtk-rs/glib#678
This PR will add container Variant API. It already adds basic array support.