This repository has been archived by the owner on Jun 8, 2021. It is now read-only.

Add a VariantIter type, and Variant::iter() method #683

Merged

sdroege merged 1 commit into gtk-rs:master from ids1024:iter

Sep 7, 2020

Contributor

ids1024 commented Sep 4, 2020

ids1024 force-pushed the iter branch from cb6b17e to 79cf207 Compare

September 5, 2020 15:44

sdroege approved these changes

View reviewed changes

sdroege reviewed

View reviewed changes

src/variant_iter.rs Show resolved Hide resolved

ids1024 mentioned this pull request

Implement FromVariant for Variant #679

Merged

ids1024 force-pushed the iter branch 2 times, most recently from e9bbdab to 5a45d2d Compare

September 7, 2020 15:37

Contributor Author

ids1024 commented Sep 7, 2020

I've updated to an implementation using g_variant_get_child_value(), which now implements ExactSizeIterator.

sdroege reviewed

View reviewed changes

src/variant_iter.rs Show resolved Hide resolved

sdroege reviewed

View reviewed changes

src/variant_iter.rs Outdated Show resolved Hide resolved

sdroege reviewed

View reviewed changes

src/variant_iter.rs Show resolved Hide resolved

sdroege reviewed

View reviewed changes

Member

sdroege left a comment

Looks good to me apart from those little details :) Thanks!

ids1024 force-pushed the iter branch from 5a45d2d to 5bc5f04 Compare

September 7, 2020 16:26


Add a VariantIter type, and Variant::iter() method

6174bbe

ids1024 force-pushed the iter branch from 5bc5f04 to 6174bbe Compare

September 7, 2020 16:26

sdroege reviewed

View reviewed changes

src/variant_iter.rs Show resolved Hide resolved

sdroege approved these changes

View reviewed changes

Member

sdroege left a comment

Will merge once the CI is through

sdroege merged commit b02fb43 into gtk-rs:master

ids1024 deleted the iter branch

September 8, 2020 03:23

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.