New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] CSub GRPC features: reflection, healthcheck #1931

Open

jeffmendoza opened this issue May 28, 2024 · 0 comments

Labels

Collaborator

jeffmendoza commented May 28, 2024

For those running csub in production, it would be great to enable healthchecking:
https://grpc.io/docs/guides/health-checking/

Also, the server is not supporting reflection, which makes using things like grpcurl require the proto files seperately.

Looks like just need some options here:
https:/guacsec/guac/blob/main/pkg/collectsub/server/server.go#L138-L146

Any concerns with enabling these?

jeffmendoza added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment