Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #2206 add http handler to display version string #2207

Conversation

nitram509
Copy link
Contributor

@nitram509 nitram509 commented Oct 20, 2024

Description of the PR

Fixes #2206

implements a simple /version endpoint, returning the server's version.

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • n/a [ ] If GraphQL schema is changed, make generate has been run
  • n/a [ ] If GraphQL schema is changed, GraphQL client updates/additions have been made
  • n/a [ ] If OpenAPI spec is changed, make generate has been run
  • n/a [ ] If ent schema is changed, make generate has been run
  • n/a [ ] If collectsub protobuf has been changed, make proto has been run
  • n/a [ ] All CI checks are passing (tests and formatting)
  • n/a [ ] All dependent PRs have already been merged

Copy link
Collaborator

@pxp928 pxp928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank You!

@kodiakhq kodiakhq bot merged commit 0b6f4a9 into guacsec:main Oct 21, 2024
8 checks passed
@nitram509 nitram509 deleted the issue-2206-feature-display-version-of-guac-for-guac-visualizer branch October 21, 2024 15:36
@nitram509
Copy link
Contributor Author

Hi @rakshitgondwal @pxp928
thanks for approving and merging this PR.
Because I'm participating in Hacktoberfest, may I ask to add the 'hacktoberfest-accepted' label, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] display version of guac for guac-visualizer
3 participants