Api and UI updates #108
Open
Api and UI updates #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes breaking API changes. We made the following API
prism-bindinglisttoprism-listbindings,prism-bindingaddtoprism-addbindingprism-bindingremovetoprism-deletebinding(The change todeleteimplies that data is being lost; in other words, outlay values are being deleted)This PR also allows prism member split values to come in as integers. Aparently JS likes to convert
1.0to1. So in the plugin we cast all incoming values to float. We also allow the destination to remain empty (rather than a BOLT12 offer). This is useful for placeholder where you want to start tracking an outlay, but don't yet have a BOLT12 offer to pay to. If you do, we now use thedecodemethod to ensure its validity. We update the tests and we also update the docker-based testing framework to an image based on 24.08.1. And readme updates. This PR would close #107 and #98