Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Episode title not parsed when file is a repack #775

Open
noxxusnx opened this issue May 12, 2024 · 2 comments · May be fixed by #788
Open

Episode title not parsed when file is a repack #775

noxxusnx opened this issue May 12, 2024 · 2 comments · May be fixed by #788

Comments

@noxxusnx
Copy link

When a filename contains "REPACK" it adds "Proper" to the tags, then for some reason no longer parses the episode title.

You can replicate with setting this up:

from guessit import guessit

file_name_original = "Total.Forgiveness.S00E01.Grant.OBrien.Its.All.Love.Full.Stand.up.Set.1080p.DRPO.WEBRip.x265.AAC.2.0-NOXXUS.mkv"
file_name_repack = "Total.Forgiveness.S00E01.REPACK.Grant.OBrien.Its.All.Love.Full.Stand.up.Set.1080p.DRPO.WEBRip.x265.AAC.2.0-NOXXUS.mkv"

Then calling guessit(file_name_original) returns:

MatchesDict({'title': 'Total Forgiveness', 'season': 0, 'episode': 1, 'episode_title': 'Grant OBrien Its All Love Full Stand up Set', 'screen_size': '1080p', 'source': 'Web', 'other': 'Rip', 'video_codec': 'H.265', 'audio_codec': 'AAC', 'audio_channels': '2.0', 'release_group': 'NOXXUS', 'container': 'mkv', 'mimetype': 'video/x-matroska', 'type': 'episode'})

Then calling guessit(file_name_repack) returns:

MatchesDict({'title': 'Total Forgiveness', 'season': 0, 'episode': 1, 'other': ['Proper', 'Rip'], 'proper_count': 1, 'screen_size': '1080p', 'source': 'Web', 'video_codec': 'H.265', 'audio_codec': 'AAC', 'audio_channels': '2.0', 'release_group': 'NOXXUS', 'container': 'mkv', 'mimetype': 'video/x-matroska', 'type': 'episode'})

Noticeably no longer returning a value for episode_title

@noxxusnx
Copy link
Author

I haven't found the cause but adding to guessit/test/rules/episodes.yml

? Some.Series.S00E01.Some.Episode.Title.1080p.WEBRip.x265.AAC.2.0-SOMEGROUP.mkv
: title: Some Series
  episode_title: Some Episode Title

? Some.Series.S00E01.REPACK.Some.Episode.Title.1080p.WEBRip.x265.AAC.2.0-SOMEGROUP.mkv
: title: Some Series
  episode_title: Some Episode Title
  proper_count: 1

Replicates the issue in tests, the first one passes and the 2nd one is missing the episode_title

@noxxusnx
Copy link
Author

Still trying to narrow things down, but with breakpoints I've found that in the EpisodeTitleFromPosition rule the hole_filter method seems to be where the problem happens. In the working test the episode variable contains <S00E01:(12, 18)+private+tags=['SxxExx']> but in the not working test it doesn't contain anything.

@noxxusnx noxxusnx linked a pull request Sep 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant