Updated to leverate the latest cloneable readable #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phated
reviewed
Sep 20, 2016
| @@ -111,10 +111,6 @@ File.prototype.clone = function(opt) { | |||
| // Clone our file contents | |||
| var contents; | |||
| if (this.isStream()) { | |||
| if (typeof this.contents.clone !== 'function') { | |||
There was a problem hiding this comment.
Should this be removed? I'm concerned that someone may set file._contents to a non-wrapped stream.
There was a problem hiding this comment.
A couple of notes here:
a. the API compatible way to set file._contents is via file.contents. Are we supporting direct access to _contents? If so, yes, we should keep that check.
b. I've added a cloneable.isCloneable(stream) which is stricter.
There was a problem hiding this comment.
Fair point, I am always scared that people will use anything exposed (even did a talk about it!)
|
I agree with you, but that's when I need to do something that is not supported by the API. contents is widely available and well documented. |
|
Thanks @mcollina! The tests are working awesome now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated for mcollina/cloneable-readable#3