use Buffer.isBuffer instead of instanceof #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2,6 +2,4 @@ var buf = require('buffer'); | |||
| var Buffer = buf.Buffer; | |||
|
|
|||
| // could use Buffer.isBuffer but this is the same exact thing... | |||
There was a problem hiding this comment.
oh yeah... good point. pushed changes
|
|
|
@contra that looks good to me, pushed that up. |
yocontra
pushed a commit
that referenced
this pull request
Aug 4, 2015
use Buffer.isBuffer instead of instanceof
|
@contra when do you think you could publish a patch version to npm? I understand if you dont want to version bump for such a small change, but it would make my life a little easier as i'm working with browserified vinyl code :) |
|
0.5.1 |
phated
pushed a commit
that referenced
this pull request
Sep 27, 2016
use Buffer.isBuffer instead of instanceof
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instanceofdoesnt work for browserified codeSo I changed this to just use Buffer.isBuffer.
probably could just remove the entire 'isBuffer' module, but I left it to be consistent with the other packages.