Fixed split with nested Compounds Issue #698

gumyr · Oct 4, 2024 · f1a9c58 · f1a9c58
1 parent 2864f05
commit f1a9c58
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/src/build123d/topology.py b/src/build123d/topology.py
@@ -2760,13 +2760,11 @@ def split(self, plane: Plane, keep: Keep = Keep.TOP) -> Self:
  # Perform the splitting operation
  splitter.Build()
 
- if keep == Keep.BOTH:
- result = Compound(downcast(splitter.Shape()))
- else:
- parts = list(Compound(downcast(splitter.Shape())))
+ result = Compound(downcast(splitter.Shape())).unwrap(fully=False)
+ if keep != Keep.BOTH:
  tops = []
  bottoms = []
- for part in parts:
+ for part in result:
  if plane.to_local_coords(part).center().Z >= 0:
  tops.append(part)
  else:

diff --git a/tests/test_build_part.py b/tests/test_build_part.py
@@ -462,6 +462,12 @@ def test_custom_plane(self):
  split(bisect_by=Plane.YZ, keep=Keep.TOP)
  self.assertAlmostEqual(test.part.volume, (2 / 3) * 1000 * pi, 5)
 
+ def test_wrapped_object(self):
+ obj = Box(1, 1, 1)
+ obj = fillet(obj.edges().group_by(Axis.Z)[-1], 0.1)
+ right = split(obj, bisect_by=Plane.YZ, keep=Keep.TOP)
+ self.assertLess(right.volume, obj.volume)
+
 
 class TestThicken(unittest.TestCase):
  def test_thicken(self):