Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revolve Axis check is too limiting #475

Closed
gumyr opened this issue Jan 11, 2024 · 1 comment
Closed

revolve Axis check is too limiting #475

gumyr opened this issue Jan 11, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@gumyr
Copy link
Owner

gumyr commented Jan 11, 2024

This code illustrates the problem:

distX = 100
distY = 50
r = 10

with BuildPart(mode=Mode.PRIVATE) as x:
    with BuildSketch(Plane.ZX) as sk:
        with Locations((0,r)):
            Rectangle(r,r, align=(Align.MIN, Align.MIN))
    revolve(revolution_arc=90, axis=Axis((-distX,distY,0 ), (0,0,1)))

image

The following checks need to be re-worked:

        # axis origin must be on the same plane as profile
        face_plane = Plane(profile)
        if not face_plane.contains(axis.position):
            raise ValueError(
                "axis origin must be on the same plane as the face to revolve"
            )
        if not face_plane.contains(axis):
            raise ValueError("axis must be in the same plane as the face to revolve")
@gumyr gumyr added the bug Something isn't working label Jan 11, 2024
@gumyr gumyr added this to the Gating Release 1.0.0 milestone Jan 11, 2024
gumyr added a commit that referenced this issue Jun 12, 2024
@gumyr
Copy link
Owner Author

gumyr commented Jun 12, 2024

I removed the axis checks and added a note that normally the axis is in the same plane as the face.

@gumyr gumyr closed this as completed Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant