Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve API consistency for solid summation #537

Closed
MatthiasJ1 opened this issue Feb 6, 2024 · 1 comment
Closed

Improve API consistency for solid summation #537

MatthiasJ1 opened this issue Feb 6, 2024 · 1 comment
Labels
enhancement New feature or request
Milestone
Gating Release 1.0.0

Comments

@MatthiasJ1
Copy link
Contributor

These are conceptually the same but only the first works

A = Sphere(1)
A + A # ok
A + A + A # ok
A = Sphere(1).solid()
A + A # ok
A + A + A # does not work
ValueError: Only shapes with the same dimension can be added
@MatthiasJ1 MatthiasJ1 changed the title Improve solid summation Improve API consistency for solid summation Feb 6, 2024
gumyr added a commit that referenced this issue Feb 6, 2024
@gumyr
Enhanced algebra boolean operations Issue #537
4498b11
@gumyr
Copy link
Owner

gumyr commented Feb 6, 2024

Fixed

@gumyr gumyr closed this as completed Feb 6, 2024
@gumyr gumyr added the enhancement New feature or request label Feb 6, 2024
@gumyr gumyr added this to the Gating Release 1.0.0 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Gating Release 1.0.0
Development

No branches or pull requests
2 participants
@gumyr @MatthiasJ1