Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for lofting faces with inner wires #449

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

MatthiasJ1
Copy link
Contributor

Automatically computes the optimal path between inner wires. Also refactors the original loft functionality so that the new version is about the same length.

a = Rot(Z=20) * (Circle(5) - GridLocations(3,0,3,1)*Circle(1))
b = Pos(0,0,10) * Rot(Z=90) * a
c = Pos(0,0,20) * (Rectangle(10,10) - GridLocations(3,0,3,1)*Rectangle(2,8))
l1 = loft([a,b,c])
Screenshot

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (cb5625c) 96.04% compared to head (fca4d54) 95.84%.

Files Patch % Lines
src/build123d/operations_part.py 37.50% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #449      +/-   ##
==========================================
- Coverage   96.04%   95.84%   -0.20%     
==========================================
  Files          24       24              
  Lines        7425     7434       +9     
==========================================
- Hits         7131     7125       -6     
- Misses        294      309      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gumyr
Copy link
Owner

gumyr commented Jan 7, 2024

This is a nice bit of added functionality to loft, thank you! I've got three requests before merging:

  1. Minimally, add unit tests to cover all of the lines in this new loft implementation. Ideally, there would be some tests of different configurations of holes to ensure the functionality is correct and stays that way.
  2. Run pylint and ensure there are no findings for this code. The pylint check was successful check in that it didn't drop below the pass threshold but doesn't indicate that things are getting worse.
  3. As discussed on Discord, please add a small description of how the association between holes is done to the docstring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants