Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added FAQ about glob imports #462

Merged
merged 2 commits into from
Jan 10, 2024
Merged

Added FAQ about glob imports #462

merged 2 commits into from
Jan 10, 2024

Conversation

barnabywalters
Copy link
Contributor

Also clearfixed previous section to prevent weird layout issues

Also clearfixed previous section to prevent weird layout issues
Copy link

codecov bot commented Jan 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5f9001d) 96.04% compared to head (b484650) 96.04%.
Report is 8 commits behind head on dev.

❗ Current head b484650 differs from pull request most recent head cf5b49e. Consider uploading reports for the commit cf5b49e to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #462   +/-   ##
=======================================
  Coverage   96.04%   96.04%           
=======================================
  Files          24       24           
  Lines        7427     7427           
=======================================
  Hits         7133     7133           
  Misses        294      294           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gumyr
Copy link
Owner

gumyr commented Jan 7, 2024

Excellent, thank you. If you don't mind, I have a minor request to go with this: please add a reference to your section here (https://build123d.readthedocs.io/en/latest/tutorial_lego.html#step-1-setup) where the current text reads: "There are over 100 python classes in build123d so we’ll just import them all with a from build123d import * but there are other options that we won’t explore here."

@barnabywalters
Copy link
Contributor Author

took me a while to figure out how to persuade sphinx to do that, but the link is in there now!

@gumyr gumyr merged commit 921fc9d into gumyr:dev Jan 10, 2024
10 checks passed
@gumyr
Copy link
Owner

gumyr commented Jan 10, 2024

Done - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants