Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import_step: do not assign labels to Compound.for_construction #663

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

mbugert
Copy link
Contributor

@mbugert mbugert commented Jul 24, 2024

This is a proposed fix for #662.

After importing a STEP file, the for_construction attribute of Compounds contain an OCP.TDF.TDF_Label. This will make Shape.__deepcopy__ fail because the label is not pickleable.
I removed the assignment of TDF_Labels to for_construction in the STEP import, and pass the label as a function argument to build_assembly instead.
I tried importing a few STEP files and it appears to work. WDYT?

@gumyr gumyr merged commit cba77ab into gumyr:dev Jul 25, 2024
11 checks passed
@gumyr
Copy link
Owner

gumyr commented Jul 25, 2024

Thanks! I had originally expected to do more with the TDF_Label stored temporarily in the for_construction attribute but as you've shown it isn't really required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants