Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing a typo on Update advantages.rst #691

Merged
merged 1 commit into from
Sep 8, 2024

Conversation

xela144
Copy link
Contributor

@xela144 xela144 commented Sep 7, 2024

Current advantages.rst embeds the wrong lines from examples/intersecting_pipes.py. With these changes, the lines you would see are

from build123d import *

with BuildPart() as pipes:
    box = Box(10, 10, 10, rotation=(10, 20, 30))
    with BuildSketch(*box.faces()) as pipe:
        Circle(4)
    extrude(amount=-5, mode=Mode.SUBTRACT)
    with BuildSketch(*box.faces()) as pipe:
        Circle(4.5)
        Circle(4, mode=Mode.SUBTRACT)
    extrude(amount=10)
    fillet(pipes.edges(Select.LAST), 0.2)

If you view the advantages.rst page today, you'll see what I'm talking about:

image

Current advantages.rst embeds the wrong lines from examples/intersecting_pipes.py. With these changes, the lines you would see are

```python
from build123d import *

with BuildPart() as pipes:
    box = Box(10, 10, 10, rotation=(10, 20, 30))
    with BuildSketch(*box.faces()) as pipe:
        Circle(4)
    extrude(amount=-5, mode=Mode.SUBTRACT)
    with BuildSketch(*box.faces()) as pipe:
        Circle(4.5)
        Circle(4, mode=Mode.SUBTRACT)
    extrude(amount=10)
    fillet(pipes.edges(Select.LAST), 0.2)
```
@jdegenstein jdegenstein merged commit 6fe67d2 into gumyr:dev Sep 8, 2024
@jdegenstein
Copy link
Collaborator

Merged, thank you for noticing and fixing this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants