You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I had a few ideas regarding functions to add to the repository.
I'm not sure how this would break the CI/CD as it did in my commit which was just a fomatting.
But I was thinking we should re-arrange the functions in the file according to their Shape?
Also I encountered few function variants of the ones which are already implemented with noise?
If required one could add them as well?
Why should we add in obj_func_demo? when another file called demo_func already exists? Any logical reasoning behind having two files?
I would suggest having a single file with all fns. Otherwise people using the api might get confused or find a missing import while importing from demo_func and obj_demo_func_demo .
Ok no problem. I will add other if I find any in the examples.
Do you mind if I add more details to demo_func related to the func shape, type in docstring?
Also I need to add refs for the function in the Readme.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
I had a few ideas regarding functions to add to the repository.
I'm not sure how this would break the CI/CD as it did in my commit which was just a fomatting.
If required one could add them as well?
Beta Was this translation helpful? Give feedback.
All reactions