[Fixed] Disable back button after "I am ready" button got pressed #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually I meant to disable it while the confetti animation is ongoing. |
|
Ok I'll make it as we start the confetti animation |
|
@guyluz11 I have disable the nav pop as soon as user taps on "I am ready" and confetti starts. |
guyluz11
requested changes
Jul 25, 2024
| @@ -25,6 +27,7 @@ class _ReadyForSessionOrganismState extends State<ReadyForSessionOrganism> { | |||
| bool confettiGotPlayed = false; | |||
|
|
|||
| void onPressed() { | |||
| widget.onTapReady?.call(); | |||
There was a problem hiding this comment.
There is no reason for this method to get called each click.
Move it under the if statement.
Also the name is incorrect, see my other comment.
Comment on lines
+244
to
+245
| return PopScope( | ||
| canPop: title != "work_timer", |
There was a problem hiding this comment.
This change does not belong to this pr, please revert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Fixed] #128