Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HEIC/HEIF support when libvips version >= 8.8 #315

Merged
merged 5 commits into from
Feb 7, 2020
Merged

Add HEIC/HEIF support when libvips version >= 8.8 #315

merged 5 commits into from
Feb 7, 2020

Conversation

vansante
Copy link
Contributor

This PR is largely the work of @jeremysf (see #298)

I have removed all parts that are not HEIF related from that other PR (the version increase, the rotation fix and the scale factor for SVG), in an effort to have a more managable PR and hopefully to get this merged faster :).

Furthermore, I have added an additional mimetype magic bytes sequence for HEIF files, which is different from HEIC files:

HEIC:

pvansanten@paul-thinkpad-tip  ~/Pictures  xxd example.heic | head
00000000: 0000 0018 6674 7970 6865 6963 0000 0000  ....ftypheic....
00000010: 6d69 6631 6865 6963 0000 0f74 6d65 7461  mif1heic...tmeta

HEIF:

pvansanten@paul-thinkpad-tip  ~/Pictures  xxd crowd_1440x960.heic | head 
00000000: 0000 0018 6674 7970 6d69 6631 0000 0000  ....ftypmif1....
00000010: 6d69 6631 6865 6963 0000 01fe 6d65 7461  mif1heic....meta

vips.go Outdated Show resolved Hide resolved
Co-Authored-By: Yoan Blanc <[email protected]>
@h2non h2non merged commit a875ddc into h2non:master Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants