Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multiple response headers with same name #35 #36

Merged
merged 1 commit into from
Sep 9, 2018
Merged

Support multiple response headers with same name #35 #36

merged 1 commit into from
Sep 9, 2018

Conversation

steinfletcher
Copy link
Contributor

This change adds support for defining multiple headers with the same name on a response. This is commonly desired when using Set-Cookie

@steinfletcher
Copy link
Contributor Author

Not sure why TestMatchQueryParams fails in CI. Doesn't seem related to changes. Flaky test?

@steinfletcher
Copy link
Contributor Author

OK, tests fail against tip - develop branch in go. I updated the config to run against stable and it passes. Not sure what the issue is with tip and how you want to proceed.

@h2non h2non merged commit 50846d9 into h2non:master Sep 9, 2018
@h2non
Copy link
Owner

h2non commented Sep 9, 2018

Cool, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@steinfletcher @h2non